----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21324/#review42753 -----------------------------------------------------------
3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment76630> brace on previous line, indent 2 within braces. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment76631> drop brace on function definitions. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment76632> EXPECT_EQ would be better as ASSERT_EQ will stop the test. - Dominic Hamon On May 12, 2014, 10:02 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21324/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 10:02 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 2nd Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 06f2596 > 3rdparty/libprocess/src/tests/http_tests.cpp f58a129 > > Diff: https://reviews.apache.org/r/21324/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
