----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21324/#review43405 -----------------------------------------------------------
Ship it! Sweet! Very minor cleanup then we'll get this committed. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77501> Prefer full names when applicable. I.e., 'request' is better than 'r' here, but for example you'll sometimes see us take a 'const string& s' just because there isn't a better identifier for the variable. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77502> Oops, bad indentation here. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77503> We try and use two newlines between top-level definitions/declarations please. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77504> To be consistent let's use 'HTTP' instead of 'http' to label these tests please. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77505> Did you want "" or None() for the third (i.e., 'query') argument? Same for the call to http::get below too. - Benjamin Hindman On May 12, 2014, 10:53 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21324/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 10:53 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 2nd Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 06f2596 > 3rdparty/libprocess/src/tests/http_tests.cpp f58a129 > > Diff: https://reviews.apache.org/r/21324/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
