> On May 19, 2014, 7:44 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 84 > > <https://reviews.apache.org/r/21324/diff/2/?file=579238#file579238line84> > > > > Did you want "" or None() for the third (i.e., 'query') argument? Same > > for the call to http::get below too.
I changed to None() to be more explicit, I think a query is not necessary for this test. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21324/#review43405 ----------------------------------------------------------- On May 19, 2014, 8:11 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21324/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 8:11 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 2nd Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 06f2596 > 3rdparty/libprocess/src/tests/http_tests.cpp f58a129 > > Diff: https://reviews.apache.org/r/21324/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
