----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21324/#review43666 -----------------------------------------------------------
3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/21324/#comment77958> Hmmm, I don't think that we should expect to get a realm from the query. The realm will be set by the actual code implementing the callback (i.e., the "origin server") when it creates an Unauthorized (IIUC). Speaking of which, we'll always want the Unauthorized constructor to take a realm so I think we'll want: Unauthorized(const std::string& realm) and Unauthorized(const std::string& realm, const std::string& body) That is, you always have to specify the realm. - Benjamin Hindman On May 21, 2014, 3:39 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21324/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 3:39 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 2nd Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 06f2596 > 3rdparty/libprocess/src/tests/http_tests.cpp f58a129 > > Diff: https://reviews.apache.org/r/21324/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
