-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21998/#review44200
-----------------------------------------------------------



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21998/#comment78526>

    CHECK_NE(-1, from);



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21998/#comment78527>

    CHECK_NE(-1, to.get())



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21998/#comment78524>

    nit: 'its lifetime' here and below.


- Dominic Hamon


On May 28, 2014, 4:48 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21998/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 4:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. Will add tests in a subsequent review. Getting this out there 
> for others to leverage first.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 
> 7f9b2420ac1568eaf81a82c189a4b445abee9a90 
>   3rdparty/libprocess/src/process.cpp 
> 58bae5b0e26acacca7e43dbde291e7700a583fd9 
> 
> Diff: https://reviews.apache.org/r/21998/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to