> On May 29, 2014, 12:33 a.m., Ben Mahler wrote: > > I realized there must be a race between open and cloexec in general, I've > > filed https://issues.apache.org/jira/browse/MESOS-1432 for this. > > > >
Thanks Ben. > On May 29, 2014, 12:33 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/io.hpp, line 72 > > <https://reviews.apache.org/r/21998/diff/2/?file=598176#file598176line72> > > > > Can you add a note on when the returned future is ready? Done. > On May 29, 2014, 12:33 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 4152-4178 > > <https://reviews.apache.org/r/21998/diff/2/?file=598177#file598177line4152> > > > > Maybe a note that these may already be nonblocking / close-on-exec, but > > this is ok? Added two comments. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21998/#review44208 ----------------------------------------------------------- On May 29, 2014, 12:48 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21998/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 12:48 a.m.) > > > Review request for mesos, Ben Mahler, Till Toenshoff, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > 7f9b2420ac1568eaf81a82c189a4b445abee9a90 > 3rdparty/libprocess/src/process.cpp > 58bae5b0e26acacca7e43dbde291e7700a583fd9 > 3rdparty/libprocess/src/tests/io_tests.cpp > 3c7b459f1238b337afada9ff94523ada2bc2b97f > > Diff: https://reviews.apache.org/r/21998/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
