> On May 28, 2014, 11:54 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 4119 > > <https://reviews.apache.org/r/21998/diff/1/?file=598175#file598175line4119> > > > > CHECK_NE(-1, from);
Good idea, added explicit checks that return Failure. > On May 28, 2014, 11:54 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 4130 > > <https://reviews.apache.org/r/21998/diff/1/?file=598175#file598175line4130> > > > > nit: 'its lifetime' here and below. Done, thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21998/#review44200 ----------------------------------------------------------- On May 29, 2014, 12:10 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21998/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 12:10 a.m.) > > > Review request for mesos, Ben Mahler, Till Toenshoff, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > 7f9b2420ac1568eaf81a82c189a4b445abee9a90 > 3rdparty/libprocess/src/process.cpp > 58bae5b0e26acacca7e43dbde291e7700a583fd9 > 3rdparty/libprocess/src/tests/io_tests.cpp > 3c7b459f1238b337afada9ff94523ada2bc2b97f > > Diff: https://reviews.apache.org/r/21998/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
