----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21998/#review44205 -----------------------------------------------------------
3rdparty/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/21998/#comment78530> style nit: Try<int> fd = os::open( path.get(), O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR | S_IRGRP | S_IRWXO); 3rdparty/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/21998/#comment78533> use os::close and check it was successful? - Dominic Hamon On May 28, 2014, 5:10 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21998/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 5:10 p.m.) > > > Review request for mesos, Ben Mahler, Till Toenshoff, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > 7f9b2420ac1568eaf81a82c189a4b445abee9a90 > 3rdparty/libprocess/src/process.cpp > 58bae5b0e26acacca7e43dbde291e7700a583fd9 > 3rdparty/libprocess/src/tests/io_tests.cpp > 3c7b459f1238b337afada9ff94523ada2bc2b97f > > Diff: https://reviews.apache.org/r/21998/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
