> On Oct. 28, 2014, 11:58 p.m., Kapil Arya wrote: > > src/master/master.cpp, lines 3879-3888 > > <https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3879> > > > > Here if the user specifies an invalid modulename but doesn't specify > > the module with --modules, shouldn't we give a simple error that the > > authenticator 'name' was not found? > > > > Sth along the lines of : > > > > } else if > > (modules::ModuleManager::contains<Authenticator>(authenticatorModules[0])) { > > ... ModuleManager::create ... > > } else { > > ERROR(invalid module) > > }
Yes, always better to have deterministic error messages where possible. Thank you! I did however move that check further up, into initialize as we can check at that point already. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58924 ----------------------------------------------------------- On Oct. 29, 2014, 5:19 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 5:19 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Enables selecting a module based authenticator via the new --authenticators > flag for mesos master. > > Additionally, all "> >" have been fixed towards ">>" in master.hpp and > master.cpp. > > > Diffs > ----- > > src/examples/test_authenticator_module.cpp PRE-CREATION > src/master/flags.hpp c931fd9 > src/master/master.hpp b1a2cd0 > src/master/master.cpp 762d2ff > src/tests/cram_md5_authentication_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
