> On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 251 > > <https://reviews.apache.org/r/28141/diff/1/?file=766639#file766639line251> > > > > This is not checkpointed so what happens if the fetcher is running and > > the slave is restarted? When it comes back it won't know about the > > fetcher... Does this rely on the fetcher being run with a pipe on stdin and > > getting sigpipe when the slave exits?
Pretty much as you described, and even if it somehow escaped since we haven't checkpointed the fetch should exit once it finished. I think I'm preserving existing behavior in this case. > On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 377 > > <https://reviews.apache.org/r/28141/diff/1/?file=766640#file766640line377> > > > > Is it true that the pid is only checkpointed after the container > > successfully launched therefore we can assume it's in the RUNNING state? > > Please add a comment. Sounds good! > On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 336 > > <https://reviews.apache.org/r/28141/diff/1/?file=766641#file766641line336> > > > > Is it feasible to add a test that verifies the fetcher is killed under > > these circumstances? Otherwise, this test would pass if the fetcher was > > simply ignored and left running. Ok I'll add one. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review61986 ----------------------------------------------------------- On Nov. 18, 2014, 12:49 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:49 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp 3baea31 > src/slave/containerizer/mesos/containerizer.cpp 562b03b > src/tests/containerizer_tests.cpp a63897b > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
