> On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 336 > > <https://reviews.apache.org/r/28141/diff/1/?file=766641#file766641line336> > > > > Is it feasible to add a test that verifies the fetcher is killed under > > these circumstances? Otherwise, this test would pass if the fetcher was > > simply ignored and left running. > > Timothy Chen wrote: > Ok I'll add one.
I just realized that the code benh did to add a pipe to kill the fetcher was reverted, as I believe we were facing problems when the patch was applied. So I don't think the fetcher actually dies when the slave is killed, and also I'm not sure how to create a test using the vanilla fetcher and also not trying to require internet connection to simluate a long fetch deterministically. Ian you have better ideas? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review61986 ----------------------------------------------------------- On Nov. 18, 2014, 12:49 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:49 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp 3baea31 > src/slave/containerizer/mesos/containerizer.cpp 562b03b > src/tests/containerizer_tests.cpp a63897b > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
