----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review62578 -----------------------------------------------------------
Ship it! Fix the Owned<> issues from buildbot + the TODO then looks good! src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/28141/#comment104650> Please add the TODO somewhere for the fetcher pid not being recovered so it could be left executing. - Ian Downes On Nov. 20, 2014, 9:40 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 9:40 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 3baea316f345aaa4abd1e16ca4ac308f0a308502 > src/slave/containerizer/mesos/containerizer.cpp > 24f90b663813e5919b9eb9e64aee006d6d0a612e > src/tests/containerizer_tests.cpp a63897b5ae01a70689714aeb0d6e33bed8b3b263 > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
