> On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 547 > > <https://reviews.apache.org/r/28141/diff/1/?file=766640#file766640line547> > > > > wrap here (and elsewhere) in CHECK_NOTNULL?
All the places already has containers_.contains(containerId) checks already. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review61986 ----------------------------------------------------------- On Nov. 18, 2014, 12:49 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:49 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp 3baea31 > src/slave/containerizer/mesos/containerizer.cpp 562b03b > src/tests/containerizer_tests.cpp a63897b > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
