----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28262/#review62250 -----------------------------------------------------------
src/proxy/proxy.hpp <https://reviews.apache.org/r/28262/#comment104257> watch your indents here src/proxy/proxy.hpp <https://reviews.apache.org/r/28262/#comment104261> std::unique_ptr src/proxy/proxy.cpp <https://reviews.apache.org/r/28262/#comment104258> check for final in configure.ac src/proxy/proxy.cpp <https://reviews.apache.org/r/28262/#comment104259> s/debug/state/ for consistency src/proxy/proxy.cpp <https://reviews.apache.org/r/28262/#comment104260> There may be race conditions here. Contrived example: If a slave fails over the master may send the attach for the new slave (with the same id) before sending the detach for the old one. It might be reasonable to detach and log instead. src/proxy/proxy.cpp <https://reviews.apache.org/r/28262/#comment104262> move this into the initializer list (especially if you make it a unique_ptr) - Dominic Hamon On Nov. 19, 2014, 2:07 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28262/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 2:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-2131 > https://issues.apache.org/jira/browse/MESOS-2131 > > > Repository: mesos-git > > > Description > ------- > > Attach/detach remote servers locally > > /proxy/debug.json lists attached endpoints. > /proxy/go/{name} forwards the rest of the path + query parameters to the > remote host. > > > Diffs > ----- > > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/proxy/proxy.hpp PRE-CREATION > src/proxy/proxy.cpp PRE-CREATION > src/tests/proxy_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28262/diff/ > > > Testing > ------- > > make check on ArchLinux, make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
