> On Nov. 19, 2014, 10:21 p.m., Dominic Hamon wrote: > > src/proxy/proxy.cpp, line 78 > > <https://reviews.apache.org/r/28262/diff/1/?file=770290#file770290line78> > > > > There may be race conditions here. > > > > Contrived example: If a slave fails over the master may send the attach > > for the new slave (with the same id) before sending the detach for the old > > one. > > > > It might be reasonable to detach and log instead.
In this case we'd also be hurt by doing the detach() after a new attach (Even passing the name + endpoint and ensuring they match wouldn't really help). I think we can guarantee that attach and detach events come in serially for slaves by either making the registrar do the update (AdmitSlave, ReadmitSlave, RemoveSlave). Or we can have them all come from the master when it processes/guarantees the events succeed (addSlave / removeSlave) > On Nov. 19, 2014, 10:21 p.m., Dominic Hamon wrote: > > src/proxy/proxy.cpp, line 62 > > <https://reviews.apache.org/r/28262/diff/1/?file=770290#file770290line62> > > > > s/debug/state/ for consistency files/files.cpp should be updated to match state as well then (We currently have state.json for master, debug.json for files, no other endpoint seems to have one) https://reviews.apache.org/r/28263/ - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28262/#review62250 ----------------------------------------------------------- On Nov. 19, 2014, 11:33 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28262/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-2131 > https://issues.apache.org/jira/browse/MESOS-2131 > > > Repository: mesos-git > > > Description > ------- > > Attach/detach remote servers locally > > /proxy/debug.json lists attached endpoints. > /proxy/go/{name} forwards the rest of the path + query parameters to the > remote host. > > > Diffs > ----- > > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/proxy/proxy.hpp PRE-CREATION > src/proxy/proxy.cpp PRE-CREATION > src/tests/proxy_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28262/diff/ > > > Testing > ------- > > make check on ArchLinux, make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
