> On Nov. 19, 2014, 11:36 p.m., Dominic Hamon wrote: > > src/proxy/proxy.hpp, line 50 > > <https://reviews.apache.org/r/28262/diff/2/?file=770550#file770550line50> > > > > do you think the process::Node should be passed by const reference?
It's small enough that a pointer is likely bigger than it (At the moment anyways), even once it takes IPv6 it still should be less than 1K in size, so the copy will be relatively cheap (And the compiler can do a lot more with a value than a reference which looks like a pointer when you get to the backend). Passing by const would work, but the eventual target is non-cost so that would cause at least the less optimized code to have more potential copies. > On Nov. 19, 2014, 11:36 p.m., Dominic Hamon wrote: > > src/proxy/proxy.cpp, line 135 > > <https://reviews.apache.org/r/28262/diff/2/?file=770551#file770551line135> > > > > do you need to do this? process will go out of scope and be destroyed > > anyway on the next line. I don't think behavior changes having it. I think it shows we want the process to go away in a specific order (Really seems like libprocess Process things should have independent lifetimes and they should be pinged to shutdown, but that is a separate issue altogether) - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28262/#review62271 ----------------------------------------------------------- On Nov. 19, 2014, 11:33 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28262/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-2131 > https://issues.apache.org/jira/browse/MESOS-2131 > > > Repository: mesos-git > > > Description > ------- > > Attach/detach remote servers locally > > /proxy/debug.json lists attached endpoints. > /proxy/go/{name} forwards the rest of the path + query parameters to the > remote host. > > > Diffs > ----- > > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/proxy/proxy.hpp PRE-CREATION > src/proxy/proxy.cpp PRE-CREATION > src/tests/proxy_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28262/diff/ > > > Testing > ------- > > make check on ArchLinux, make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
