----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28262/#review62287 -----------------------------------------------------------
Ship it! Ship It! src/proxy/proxy.cpp <https://reviews.apache.org/r/28262/#comment104315> you're right, behaviour doesn't change. but explicit calls to reset on a unique_ptr are an anti-pattern that cause readers of the code to think about why this is necessary. the unique_ptr is a member and will be destroyed at the end of ~Proxy. This mirrors its construction at the beginning of Proxy::Proxy. i don't mind if it's there or not, but i think it's cleaner to not have it and use the unique_ptr scope how it is meant to be used. - Dominic Hamon On Nov. 19, 2014, 3:33 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28262/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 3:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-2131 > https://issues.apache.org/jira/browse/MESOS-2131 > > > Repository: mesos-git > > > Description > ------- > > Attach/detach remote servers locally > > /proxy/debug.json lists attached endpoints. > /proxy/go/{name} forwards the rest of the path + query parameters to the > remote host. > > > Diffs > ----- > > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/proxy/proxy.hpp PRE-CREATION > src/proxy/proxy.cpp PRE-CREATION > src/tests/proxy_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28262/diff/ > > > Testing > ------- > > make check on ArchLinux, make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
