----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review64114 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment106552> Wrap comments by 70 chars. include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment106888> Given the comments here, it's better to move this field closer to 'role': ``` // Your comments here. optional string role; optional Reservation reservation; ``` include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment106886> Is there any other place that we will use ReservationType? If not, make it nested inside Resource looks better to me. ``` messasge Resource { ... message Reservation { STATIC = 1; DYNAMIC = 2; } optional Reservation reservation = 8; } ``` include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment106889> I am still not sure about this. Can we simply use repeated Resource in Launch for now to simplify interfaces (meaning that we acquire/release some "resources" for reservation)? - Jie Yu On Dec. 5, 2014, 10:18 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28697/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:18 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2137 > https://issues.apache.org/jira/browse/MESOS-2137 > > > Repository: mesos-git > > > Description > ------- > > Adding new protobuf messages necessary to support dynamic reservations. Work > in progress. > > > Diffs > ----- > > include/mesos/mesos.proto e0b6375579ca7d3af03e4b59044810b8b7d2df86 > > Diff: https://reviews.apache.org/r/28697/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
