----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review65519 -----------------------------------------------------------
Ship it! The protobufs themselves look fine, but we'll need a lot more documentation on the proper way to use these fields together. include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment108775> Maybe more important than listing the valid states would be to list the valid transitions for framework writers (maybe in a lengthier doc), since a framework cannot, for example, change "role=R, STATIC" to "role=R, DYNAMIC". include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment108741> Should this be called ReservationType instead, in case we do want/need a true Reservation struct later? include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment108774> About half of our protobuf enums start at 0, the others at 1. Do you have any reason to reserve 0 for later/NULL? include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment108773> Framework writers will definitely need more documentation than this about dynamic reservations. Probably worth a separate subtask and review for a docs/reservations.md - Adam B On Dec. 16, 2014, 4:56 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28697/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 4:56 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2137 > https://issues.apache.org/jira/browse/MESOS-2137 > > > Repository: mesos-git > > > Description > ------- > > Adding new protobuf messages necessary to support dynamic reservations. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > > Diff: https://reviews.apache.org/r/28697/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
