> On Dec. 18, 2014, 10:43 p.m., Adam B wrote: > > The protobufs themselves look fine, but we'll need a lot more documentation > > on the proper way to use these fields together.
Agreed. Added a JIRA ticket to track this: https://issues.apache.org/jira/browse/MESOS-2205 > On Dec. 18, 2014, 10:43 p.m., Adam B wrote: > > include/mesos/mesos.proto, lines 402-404 > > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line402> > > > > Framework writers will definitely need more documentation than this > > about dynamic reservations. Probably worth a separate subtask and review > > for a docs/reservations.md Are framework writers expected to (or already does) use `<include/mesos/mesos.proto>` as documentation? Does it suffice to add the `docs/reservations.md`? or should I modify this comment to be more detailed as well? > On Dec. 18, 2014, 10:43 p.m., Adam B wrote: > > include/mesos/mesos.proto, lines 391-394 > > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line391> > > > > Maybe more important than listing the valid states would be to list the > > valid transitions for framework writers (maybe in a lengthier doc), since a > > framework cannot, for example, change "role=R, STATIC" to "role=R, DYNAMIC". Do you think it needs to be included in this comment? or should it go into `docs/reservations.md`? - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review65519 ----------------------------------------------------------- On Dec. 17, 2014, 12:56 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28697/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 12:56 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2137 > https://issues.apache.org/jira/browse/MESOS-2137 > > > Repository: mesos-git > > > Description > ------- > > Adding new protobuf messages necessary to support dynamic reservations. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > > Diff: https://reviews.apache.org/r/28697/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
