> On Dec. 18, 2014, 10:43 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 397 > > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line397> > > > > Should this be called ReservationType instead, in case we do want/need > > a true Reservation struct later?
Done. > On Dec. 18, 2014, 10:43 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 398 > > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line398> > > > > About half of our protobuf enums start at 0, the others at 1. Do you > > have any reason to reserve 0 for later/NULL? No reason to reserve for 0. I fell into the trap of thinking it needed to start 1 similar to fields of messages :( - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review65519 ----------------------------------------------------------- On Dec. 30, 2014, 2:42 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28697/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 2:42 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2137 > https://issues.apache.org/jira/browse/MESOS-2137 > > > Repository: mesos-git > > > Description > ------- > > Adding new protobuf messages necessary to support dynamic reservations. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > > Diff: https://reviews.apache.org/r/28697/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
