----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review66666 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110234> this being public is worrying as it suggests that callsites are responsible for understanding the difference between address families. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110235> explicit for one-argument constructors please to avoid unexpected conversions. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110236> add an else to catch bad families. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110237> check the family explicitly and add an error condition for unknown family_ 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110238> this should error if family_ is AF_INET6 - Dominic Hamon On Dec. 29, 2014, 9:51 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 9:51 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class Address encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 80578e2207d5436a4414f56417a0fee06ca9a7e9 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
