> On Jan. 5, 2015, 9:36 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 388 > > <https://reviews.apache.org/r/29288/diff/3/?file=803230#file803230line388> > > > > this being public is worrying as it suggests that callsites are > > responsible for understanding the difference between address families. > > Evelina Dumitrescu wrote: > I don't understand this. We need to check the family type only in the > Address internal methods or in some wrappers(eg: getIP).
sorry, i read it as being public. could you put it in an explicit 'private' section and move that section below the public methods please? > On Jan. 5, 2015, 9:36 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 427 > > <https://reviews.apache.org/r/29288/diff/3/?file=803230#file803230line427> > > > > add an else to catch bad families. > > Evelina Dumitrescu wrote: > I don't think the Error messages with unsupported family types are > necessary anymore due to the signatures of the constructors and the private > access modifier of the family variable you're right. but if someone changes the code later and makes a mistake, it'd be good to catch it. defensive programming is best programming :) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review66666 ----------------------------------------------------------- On Jan. 6, 2015, 6:17 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 6:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class Address encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 80578e2207d5436a4414f56417a0fee06ca9a7e9 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
