----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review67122 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110947> ABORT("Unsupported family type: " + stringify(that.family()); might be cleaner (and should work). (other examples of this are below.. please fix them all). 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110948> please drop the else as you have below in ipv6Address() 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110949> indent is off. check the style guide at mesos.apache.org for examples. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110950> oops. indent. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110951> indent! 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110952> can this take an Address and return sockaddr_storage and handle both ipv4 and ipv6? getHostname below would then be simpler. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110956> why pass in the family? is this temporary because we're not ready to support ipv6 throughout? 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/29288/#comment110954> fix your indents throughout. 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp <https://reviews.apache.org/r/29288/#comment110957> can you make this a separate test please? - Dominic Hamon On Jan. 7, 2015, 10:16 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 10:16 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class Address encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 80578e2207d5436a4414f56417a0fee06ca9a7e9 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
