> On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 75 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line75> > > > > Delete infos as well?
Good catch! Thanks! > On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 128 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line128> > > > > I think it's a good idea to print the container id in the error message > > for easier debug. In such cases, we usually defer the printing to the caller. > On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 139 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line139> > > > > I think it's a good idea to print the container id in the error message > > for easier debug. Same as above. > On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 386 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line386> > > > > I think one problem that I hit in when reading docker ps output through > > io:read, was that the docker ps stdout exceeded the buffer size and > > s.get().status() is stuck forever since waitpid never succeeds as the > > process was waiting for a reader forever. > > > > du -k -a depending on how many files are in the path I'm thinking > > potentially can also have a large output, so I think we should consider > > reading stdout early. I don't think it's a problem here because I used 'du -k -s' which only prints one line. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/#review67176 ----------------------------------------------------------- On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29688/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 12:45 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker > to check disk usage by calling 'du'. The DiskUsageChecker is throttled (see > comments). The isolator uses DiskUsageChecker to enforce disk quota. > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/slave/containerizer/isolators/disk_quota.hpp PRE-CREATION > src/slave/containerizer/isolators/disk_quota.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 > > Diff: https://reviews.apache.org/r/29688/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
