-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67239
-----------------------------------------------------------



src/slave/containerizer/isolators/disk_quota.hpp
<https://reviews.apache.org/r/29688/#comment111161>

    explicit on one-arg constructors



src/slave/containerizer/isolators/disk_quota.hpp
<https://reviews.apache.org/r/29688/#comment111163>

    explicit



src/slave/containerizer/isolators/disk_quota.hpp
<https://reviews.apache.org/r/29688/#comment111166>

    unique_ptr? :)



src/slave/containerizer/isolators/disk_quota.cpp
<https://reviews.apache.org/r/29688/#comment111172>

    unique_ptr!



src/slave/containerizer/isolators/disk_quota.cpp
<https://reviews.apache.org/r/29688/#comment111179>

    unique_ptr? :)


- Dominic Hamon


On Jan. 7, 2015, 4:45 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29688/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 4:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker 
> to check disk usage by calling 'du'. The DiskUsageChecker is throttled (see 
> comments). The isolator uses DiskUsageChecker to enforce disk quota.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
>   src/slave/containerizer/isolators/disk_quota.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/disk_quota.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 
> 
> Diff: https://reviews.apache.org/r/29688/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to