> On Jan. 8, 2015, 7:39 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 400 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line400> > > > > What errors do you expect that are transient and imply we can retry? > > > > Can we verify correct functionality of du at initialization and then > > not reschedule on unexpected failure?
Added a retry limit and a TODO. > On Jan. 8, 2015, 7:39 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 159 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line159> > > > > This is true in the current Mesos containerizer code but this behavior > > could be changed to be configurable so it should not be assumed in any > > isolator. Since Limitation has already been set, there is no point continuing monitoring the disk usage, right? Anyway, we need to revisit this once we allow other strategy when Limitation is reached (we might need to update the current interfaces). > On Jan. 8, 2015, 7:39 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 256 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line256> > > > > As above, the isolator should not assume the containerizer will kill > > the container after the Limitation so it should wait until cleanup() before > > stopping everything. See above. I added TODO's here. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/#review67244 ----------------------------------------------------------- On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29688/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 12:45 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker > to check disk usage by calling 'du'. The DiskUsageChecker is throttled (see > comments). The isolator uses DiskUsageChecker to enforce disk quota. > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/slave/containerizer/isolators/disk_quota.hpp PRE-CREATION > src/slave/containerizer/isolators/disk_quota.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 > > Diff: https://reviews.apache.org/r/29688/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
