> On Jan. 8, 2015, 7:39 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/disk_quota.cpp, line 159 > > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line159> > > > > This is true in the current Mesos containerizer code but this behavior > > could be changed to be configurable so it should not be assumed in any > > isolator. > > Jie Yu wrote: > Since Limitation has already been set, there is no point continuing > monitoring the disk usage, right? Anyway, we need to revisit this once we > allow other strategy when Limitation is reached (we might need to update the > current interfaces).
If we start to report disk usage using this isolator, then keep monitoring the disk usage does make sense. I'll address this. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/#review67244 ----------------------------------------------------------- On Jan. 9, 2015, 1:37 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29688/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 1:37 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker > to check disk usage by calling 'du'. The DiskUsageChecker is throttled (see > comments). The isolator uses DiskUsageChecker to enforce disk quota. > > > Diffs > ----- > > src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 > src/slave/containerizer/isolators/disk_quota.hpp PRE-CREATION > src/slave/containerizer/isolators/disk_quota.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > > Diff: https://reviews.apache.org/r/29688/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
