> On Jan. 14, 2015, 11:36 p.m., Niklas Nielsen wrote: > > src/master/allocator.hpp, line 227 > > <https://reviews.apache.org/r/29890/diff/1/?file=821527#file821527line227> > > > > Did you run into any problems making it owned? If not, can we do it now?
No, just postponed it for a separate review to keep things simple: https://reviews.apache.org/r/29926/ > On Jan. 14, 2015, 11:36 p.m., Niklas Nielsen wrote: > > src/tests/cluster.hpp, lines 100-101 > > <https://reviews.apache.org/r/29890/diff/1/?file=821530#file821530line100> > > > > How is this different from before? > > Alexander Rukletsov wrote: > No, just postponed it for a separate review to keep things simple: > https://reviews.apache.org/r/29926/ Before we were provided with AllocatorProcess managed by the caller, that we wrapped into an Allocator instance managed by the class instance. Now we accept Allocator instance directly. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68160 ----------------------------------------------------------- On Jan. 15, 2015, 5:13 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29890/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 5:13 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Introduce a basic Allocator interface that every allocator should implement. > This interface does not require allocators to be based on libprocess process. > For allocators they do implement allocation logic via an internal libprocess > process, a special wrapper is provided. Allocator uses and tests are updated > to use Allocator type instead of AllocatorProcess. > > [WIP]: more refactoring will be done either in an update to this RR or in a > separate RR. > > > Diffs > ----- > > src/local/local.cpp 76e73a4 > src/master/allocator.hpp 224569a > src/master/hierarchical_allocator_process.hpp ccd37b4 > src/master/main.cpp 193d53f > src/tests/cluster.hpp 74cedb3 > src/tests/hierarchical_allocator_tests.cpp 7c05123 > src/tests/master_allocator_tests.cpp 2430622 > src/tests/mesos.hpp 591134b > src/tests/mesos.cpp 3b98c69 > src/tests/resource_offers_tests.cpp d098e70 > src/tests/slave_recovery_tests.cpp 809822e > > Diff: https://reviews.apache.org/r/29890/diff/ > > > Testing > ------- > > make distcheck (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
