----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68273 -----------------------------------------------------------
src/master/allocator.hpp <https://reviews.apache.org/r/29890/#comment112707> This is the public API for _______ (fill blank) :) src/master/allocator.hpp <https://reviews.apache.org/r/29890/#comment112706> Nit: "Add explanatory comments ..." or simply "Document API calls". src/master/allocator.hpp <https://reviews.apache.org/r/29890/#comment112708> 'There is no need ...' src/master/allocator.hpp <https://reviews.apache.org/r/29890/#comment112709> s/Extract/Move/ src/tests/cluster.hpp <https://reviews.apache.org/r/29890/#comment112448> Why have both? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29890/#comment112711> The destructor of the MesosAllocator will stop the process, right? How is this different from status quo, or are you trying to solve other problems mid-way? - Niklas Nielsen On Jan. 15, 2015, 9:17 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29890/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 9:17 a.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Introduce a basic Allocator interface that every allocator should implement. > This interface does not require allocators to be based on libprocess process. > For allocators they do implement allocation logic via an internal libprocess > process, a special wrapper is provided. Allocator uses and tests are updated > to use Allocator type instead of AllocatorProcess. > > > Diffs > ----- > > src/local/local.cpp 76e73a4 > src/master/allocator.hpp 224569a > src/master/hierarchical_allocator_process.hpp ccd37b4 > src/master/main.cpp 193d53f > src/tests/cluster.hpp 74cedb3 > src/tests/hierarchical_allocator_tests.cpp 7c05123 > src/tests/master_allocator_tests.cpp 2430622 > src/tests/mesos.hpp 591134b > src/tests/mesos.cpp 3b98c69 > src/tests/resource_offers_tests.cpp d098e70 > src/tests/slave_recovery_tests.cpp 809822e > > Diff: https://reviews.apache.org/r/29890/diff/ > > > Testing > ------- > > make distcheck (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
