> On Jan. 18, 2015, 1:06 p.m., Bernd Mathiske wrote: > > src/master/allocator.hpp, line 227 > > <https://reviews.apache.org/r/29890/diff/2/?file=822657#file822657line227> > > > > Not sure if that is needed. It seems to be a common accepted pattern > > the way it is.
You are right, we decided to be consistent with the current usage pattern. > On Jan. 18, 2015, 1:06 p.m., Bernd Mathiske wrote: > > src/master/hierarchical_allocator_process.hpp, line 56 > > <https://reviews.apache.org/r/29890/diff/2/?file=822658#file822658line56> > > > > Is this still needed? > > If not, this also affects the comment just above. This patch doesn't touch the way Hierarchical DRF allocator is declared and implemented. These `typedef`s are used for creating allocator instances throughout the code. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68561 ----------------------------------------------------------- On Jan. 15, 2015, 5:17 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29890/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 5:17 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Introduce a basic Allocator interface that every allocator should implement. > This interface does not require allocators to be based on libprocess process. > For allocators they do implement allocation logic via an internal libprocess > process, a special wrapper is provided. Allocator uses and tests are updated > to use Allocator type instead of AllocatorProcess. > > > Diffs > ----- > > src/local/local.cpp 76e73a4 > src/master/allocator.hpp 224569a > src/master/hierarchical_allocator_process.hpp ccd37b4 > src/master/main.cpp 193d53f > src/tests/cluster.hpp 74cedb3 > src/tests/hierarchical_allocator_tests.cpp 7c05123 > src/tests/master_allocator_tests.cpp 2430622 > src/tests/mesos.hpp 591134b > src/tests/mesos.cpp 3b98c69 > src/tests/resource_offers_tests.cpp d098e70 > src/tests/slave_recovery_tests.cpp 809822e > > Diff: https://reviews.apache.org/r/29890/diff/ > > > Testing > ------- > > make distcheck (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
