> On Jan. 16, 2015, 8:26 p.m., Niklas Nielsen wrote: > > src/tests/cluster.hpp, lines 128-129 > > <https://reviews.apache.org/r/29890/diff/2/?file=822660#file822660line128> > > > > Why have both?
If we don't specify an allocator explicitly, we would like to have a default. This is consistent with the previous behaviour. > On Jan. 16, 2015, 8:26 p.m., Niklas Nielsen wrote: > > src/tests/master_allocator_tests.cpp, lines 79-82 > > <https://reviews.apache.org/r/29890/diff/2/?file=822662#file822662line79> > > > > The destructor of the MesosAllocator will stop the process, right? How > > is this different from status quo, or are you trying to solve other > > problems mid-way? By removing these lines I change the original logic, which is restored in [this patch](https://reviews.apache.org/r/29927/). Hence the comment. A use case for the original behaviour: we would like to stop allocation but we are not managing the lifetime of the allocator instance. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68273 ----------------------------------------------------------- On Jan. 15, 2015, 5:17 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29890/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 5:17 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Introduce a basic Allocator interface that every allocator should implement. > This interface does not require allocators to be based on libprocess process. > For allocators they do implement allocation logic via an internal libprocess > process, a special wrapper is provided. Allocator uses and tests are updated > to use Allocator type instead of AllocatorProcess. > > > Diffs > ----- > > src/local/local.cpp 76e73a4 > src/master/allocator.hpp 224569a > src/master/hierarchical_allocator_process.hpp ccd37b4 > src/master/main.cpp 193d53f > src/tests/cluster.hpp 74cedb3 > src/tests/hierarchical_allocator_tests.cpp 7c05123 > src/tests/master_allocator_tests.cpp 2430622 > src/tests/mesos.hpp 591134b > src/tests/mesos.cpp 3b98c69 > src/tests/resource_offers_tests.cpp d098e70 > src/tests/slave_recovery_tests.cpp 809822e > > Diff: https://reviews.apache.org/r/29890/diff/ > > > Testing > ------- > > make distcheck (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
