----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30015/#review68738 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/30015/#comment113138> s/long/size_t/ also, be explicit in the name: numberOfLinks 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/30015/#comment113139> have you built and tested this on OSX? I think the behaviour is the same between Linux and BSD (and thus OSX) but worth checking. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/30015/#comment113140> maybe cast the return to a size_t after checking for <0? - Dominic Hamon On Jan. 18, 2015, 8:56 a.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30015/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2015, 8:56 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos-git > > > Description > ------- > > Adding methods to fetch the number of hard links associated with a path as > well as the limit. > It uses the lstat and pathconf system calls to get these two numbers > respectively. > This will help the garbage collector of the slave process to take the number > of hard links into account when scheduling a directory for garbage collection. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0446f6a5d5628f8566d4cbaf33dee29b52c3c42e > > Diff: https://reviews.apache.org/r/30015/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > Ritwik Yadav > >
