> On Feb. 12, 2015, 8:24 p.m., Kapil Arya wrote: > > Is the idea here to allow the label decorator hooks to remove the labels as > > well?
Don't we also want the label removal facility in the slave instead of the master? It doesn't make much sense to remove labels in the master. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review72301 ----------------------------------------------------------- On Feb. 12, 2015, 8:13 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 8:13 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b > src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 > src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
