-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30971/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 6 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

* The approach is now to add the '`uuid`' to StatusUpdate to avoid an API 
signature change.
* The scheduler driver and executor driver overwrite this field for now. Left a 
TODO to allow executor generated UUIDs, for pure language bindings.
* Added documentation about updates w/o slave ids, that these should not be 
acknowledged (due to the API requiring a slave id). The driver attempt to warn 
about this being done accidentally by detecting an empty slave id.


Bugs: MESOS-2347
    https://issues.apache.org/jira/browse/MESOS-2347


Repository: mesos


Description
-------

Introduced explicit status update acknowledgements on the driver.


Diffs (updated)
-----

  include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 
  include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 
  src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36 
  src/exec/exec.cpp 8250bd4ec9028fb4667b9c703a2bb780fbf2171e 
  src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 
  src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 

Diff: https://reviews.apache.org/r/30971/diff/


Testing
-------

Added tests in subsequent reviews.


Thanks,

Ben Mahler

Reply via email to