----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30971/#review72779 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/30971/#comment118846> How about: // Uniquely identifies this status for the task. The status // is considered delivered once it is acknowledged by the // scheduler. Schedulers can choose to either explicitly // acknowledge the status or let the scheduler driver // implicitly acknowledge it (default). include/mesos/scheduler.hpp <https://reviews.apache.org/r/30971/#comment118862> Can you add a comment here pointing them to read comments in statusUpdate() about the acknowledgement semantics? src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment118864> s/Received/Ignoring/ src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment118876> so if this call is called twice with the same uuid (maybe due to a bug in the scheduler), the 2nd one will go to the master, right? is that safe? if not, the master should have the logic to drop these too. either way, it sounds like this dropping logic could just exist in single place, the master? src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment118865> s/Received/Ignoring/ src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment118866> s/set/set; dropping it/ - Vinod Kone On Feb. 17, 2015, 6 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30971/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 6 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > Introduced explicit status update acknowledgements on the driver. > > > Diffs > ----- > > include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 > include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 > src/common/protobuf_utils.cpp c398c58511d74c33f24002f79c01fcd45842df36 > src/exec/exec.cpp 8250bd4ec9028fb4667b9c703a2bb780fbf2171e > src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 > src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 > > Diff: https://reviews.apache.org/r/30971/diff/ > > > Testing > ------- > > Added tests in subsequent reviews. > > > Thanks, > > Ben Mahler > >
