> On Feb. 19, 2015, 9:27 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 1125 > > <https://reviews.apache.org/r/30971/diff/3/?file=868390#file868390line1125> > > > > s/Dropping/Ignoring/ to be consistent with how we logged everything > > else in this file?
N/A now that it takes `TaskStatus`. > On Feb. 19, 2015, 9:27 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 1133 > > <https://reviews.apache.org/r/30971/diff/3/?file=868390#file868390line1133> > > > > ditto. s/Dropping/Ignoring/ N/A now that it takes `TaskStatus`. > On Feb. 19, 2015, 9:27 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, lines 1785-1789 > > <https://reviews.apache.org/r/30971/diff/3/?file=868390#file868390line1785> > > > > A CHECK for a user error is weird. Lets use abort() like we did in > > start(). Sounds good, went with ABORT(). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30971/#review73196 ----------------------------------------------------------- On Feb. 21, 2015, 10:14 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30971/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > Introduced explicit status update acknowledgements on the driver. > > > Diffs > ----- > > include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 > include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 > src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 > src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 > > Diff: https://reviews.apache.org/r/30971/diff/ > > > Testing > ------- > > Added tests in subsequent reviews. > > > Thanks, > > Ben Mahler > >
