> On Feb. 20, 2015, 2:36 a.m., Benjamin Hindman wrote: > > include/mesos/scheduler.hpp, lines 282-285 > > <https://reviews.apache.org/r/30971/diff/3/?file=868389#file868389line282> > > > > Any reason not to just: > > > > Status acknowledge(const TaskStatus& status) = 0; > > > > Then down below you can do a 'status.has_uuid()'.
Nice! Thanks for this! I like the succinct `acknowledg`, but I kept the name as `acknowledgeStatusUpdate` to keep it consistent with the existing style of the function names on the driver. > On Feb. 20, 2015, 2:36 a.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 788 > > <https://reviews.apache.org/r/30971/diff/3/?file=868388#file868388line788> > > > > s/once it/once if it/ Did you want "if it is" or "once it is"? > On Feb. 20, 2015, 2:36 a.m., Benjamin Hindman wrote: > > src/sched/sched.cpp, line 1121 > > <https://reviews.apache.org/r/30971/diff/3/?file=868390#file868390line1121> > > > > s/uuid/UUID/ s/id/ID/ Acronyms! Thanks for catching this, N/A with the updated change. Mostly I referred to 'uuid' and 'slave_id' quoted as fields in the new change. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30971/#review73242 ----------------------------------------------------------- On Feb. 21, 2015, 10:14 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30971/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > Introduced explicit status update acknowledgements on the driver. > > > Diffs > ----- > > include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 > include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 > src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 > src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 > > Diff: https://reviews.apache.org/r/30971/diff/ > > > Testing > ------- > > Added tests in subsequent reviews. > > > Thanks, > > Ben Mahler > >
