----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76933 -----------------------------------------------------------
Thanks for improving this part! While you are at it, could you have a closer examine of the use of assert and expect? I wasn't very clear about the following distinction writing some of these tests: https://code.google.com/p/googletest/wiki/Primer#Assertions https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement about CHECK_*, my current understanding is they are not from gtest, so personally i think we should only use expect and assert in tests which are gtest utilities. But this is obviously not the case currently. - Chi Zhang On March 17, 2015, 6:56 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32133/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 6:56 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor port isolator tests to break out helper functions for testing of > bandwidth limit statistics > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96 > > Diff: https://reviews.apache.org/r/32133/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
