> On March 18, 2015, 8:58 p.m., Jie Yu wrote: > > Looking at all the port mapping isolator tests here, they are pretty much > > duplicating logics in MesosContainerier (e.g., launchHelper, > > statisticsHelper). It's not good for readability. > > > > It would be cool if we can simply write integration tests and use > > MesosContainerizer and command line executor directly, that can simplify > > the code a lot and make it more readable.
Agreed but beyond the scope of this change. I have refactored within port_mapping_tests.cpp to eliminate duplication where I can. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76943 ----------------------------------------------------------- On March 17, 2015, 6:56 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32133/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 6:56 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor port isolator tests to break out helper functions for testing of > bandwidth limit statistics > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96 > > Diff: https://reviews.apache.org/r/32133/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
