> On March 17, 2015, 5:51 p.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, lines 266-286 > > <https://reviews.apache.org/r/32133/diff/1/?file=896458#file896458line266> > > > > I don't see the value in pulling these out as separate functions > > compared to the original code? _Perhaps_ a single function that took the > > pXX to find?
Functions are broken out here in preparation for use in subsequent patches - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76744 ----------------------------------------------------------- On March 17, 2015, 6:56 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32133/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 6:56 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor port isolator tests to break out helper functions for testing of > bandwidth limit statistics > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96 > > Diff: https://reviews.apache.org/r/32133/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
