> On March 17, 2015, 5:51 p.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, line 196 > > <https://reviews.apache.org/r/32133/diff/1/?file=896458#file896458line196> > > > > Why an empty JSON object rather than a Try<JSON::Object>?
Current implementation of the mesos-network-helper has the helper exiting with return code 1 and no output if the network namespace identified by pid does not exist (possible due to race conditions). I will modify the helper to return a JSON object with an error message to allow easier identification of this situation. With this change, we would return an JSON object under all circumstances although only the error field might be set. > On March 17, 2015, 5:51 p.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, line 676 > > <https://reviews.apache.org/r/32133/diff/1/?file=896458#file896458line676> > > > > Better would be if waitForFileCreation() returned a Future<bool> that > > was ready when the path existed. Then you could do AWAIT_READY() and the > > (configurable) timeout would be in the caller waiting on the future, not in > > the helper. > > > > I could imagine this would be generally useful; consider adding this to > > stout? Will abstract out waitForFileCreation as separate ticket - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32133/#review76744 ----------------------------------------------------------- On March 17, 2015, 6:56 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32133/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 6:56 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Refactor port isolator tests to break out helper functions for testing of > bandwidth limit statistics > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96 > > Diff: https://reviews.apache.org/r/32133/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
