----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78421 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127084> how about at least have this function return a future and change call sites to use AWAIT_READY? When this goes into the library, the tests don't have to be changed anymore. More useful, AWAIT_READY supports timeout and has a default timeout time of 10s so you can save the timeout logic here. It'd be great see this in the library code! - Chi Zhang On March 31, 2015, 3:33 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32653/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 3:33 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Replace busy look on ready file with a more relaxed loop > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3 > > Diff: https://reviews.apache.org/r/32653/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
