> On March 31, 2015, 10:42 p.m., Chi Zhang wrote: > > src/tests/port_mapping_tests.cpp, line 396 > > <https://reviews.apache.org/r/32653/diff/2/?file=910398#file910398line396> > > > > how about at least have this function return a future and change call > > sites to use AWAIT_READY? > > > > When this goes into the library, the tests don't have to be changed > > anymore. > > > > More useful, AWAIT_READY supports timeout and has a default timeout > > time of 10s so you can save the timeout logic here. > > > > It'd be great see this in the library code!
Good idea but not required for this change. I will make this a TODO so that we can quickly fix the current issue where a failure can cause the test to hang forever. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78421 ----------------------------------------------------------- On April 1, 2015, 3:43 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32653/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:43 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Replace busy look on ready file with a more relaxed loop > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 > > Diff: https://reviews.apache.org/r/32653/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
