----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78605 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127506> Kill this extra line. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127519> TODO(pbrett): Consider generalizing this function and moving it to a common header. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127505> static bool waitForFileCreation src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127511> s/timeout/duration/ since we have process::Timeout (Clock aware), it's better to avoid confusion here. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127507> 60seconds might be too long. Probably change it to 15 seconds so that it's consistent with AWAIT_READY default. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127520> Please include <stout/stopwatch.hpp> src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32653/#comment127512> s/Seconds(0)/Duration::zero()/ - Jie Yu On April 1, 2015, 8:54 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32653/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 8:54 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Replace busy look on ready file with a more relaxed loop > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 > > Diff: https://reviews.apache.org/r/32653/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
