jhorcicka commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r331890868
##########
File path:
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -267,6 +264,10 @@ public static ColumnType
getColumnTypeFromElasticSearchType(final String metaDat
}
public static Row createRow(final Map<String, Object> sourceMap, final
String documentId, final DataSetHeader header) {
+ if (sourceMap == null) {
+ return null;
Review comment:
This was added because of a NPE; and it fixes that problem.
However, it changed the functionality a bit. Previous version returned a Row
containing null values. This returns null immediately.
In extension_elasticsearch (our internal project) I added a null check to
make it work fine with this, but I am not sure if this causes the same problem
somewhere else or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
