jhorcicka commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r331913773
##########
File path:
elasticsearch/rest/src/test/java/org/apache/metamodel/elasticsearch/rest/ElasticSearchRestDataContextIT.java
##########
@@ -347,8 +361,16 @@ public void run(UpdateCallback callback) {
@Test
public void testWhereColumnEqualsValues() throws Exception {
- try (DataSet ds =
dataContext.query().from(bulkIndexType).select("user").and("message").where("user")
- .isEquals("user4").execute()) {
+ indexBulkDocuments(INDEX_NAME, 10);
+
+ try (DataSet ds = dataContext
Review comment:
I'd rather use a better name for "ds", everywhere (dataSet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
