jhorcicka commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r331911500
##########
File path:
elasticsearch/rest/src/test/java/org/apache/metamodel/elasticsearch/rest/ElasticSearchRestDataContexFactoryIT.java
##########
@@ -55,22 +63,24 @@
public void setUp() throws Exception {
dockerHostAddress = ElasticSearchRestDataContextIT.determineHostName();
- externalClient = new ElasticSearchRestClient(RestClient.builder(new
HttpHost(dockerHostAddress, 9200)).build());
+ externalClient = new RestHighLevelClient(RestClient.builder(new
HttpHost(dockerHostAddress, 9200)));
Review comment:
9200 is actually used on multiple locations in this module. A constant would
be nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
