jhorcicka commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r331889399
##########
File path:
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -81,11 +81,8 @@ public static QueryBuilder getExistsQuery(String fieldName)
{
propertiesMap.put(fieldName, propertyMap);
}
- HashMap<String, Map<String, Map<String, String>>> docTypeMap = new
HashMap<>();
- docTypeMap.put("properties", propertiesMap);
-
- final Map<String, Map<String, Map<String, Map<String, String>>>>
mapping = new HashMap<>();
- mapping.put(table.getName(), docTypeMap);
+ final Map<String, Map<String, Map<String, String>>> mapping = new
HashMap<>();
+ mapping.put("properties", propertiesMap);
Review comment:
This key ("properties") is used at multiple locations. I'd make it a
constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
