[GitHub] [metamodel] SociopathicPixel commented on a change in pull request #230: dev/add datatypes to excel columns

[GitBox]

SociopathicPixel commented on a change in pull request #230: dev/add datatypes 
to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r334510965
 
 

 ##########
 File path: 
excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
 ##########
 @@ -169,21 +180,83 @@ private MutableTable createTable(final Workbook wb, 
final Sheet sheet) {
             }
 
             if (hasColumns) {
-                createColumns(table, wb, row);
+                createColumns(table, wb, row, columnTypes);
             }
         }
 
         return table;
     }
 
+    private ColumnType[] getColumnTypes(final Sheet sheet, final Row row) {
+        final Iterator<Row> data = ExcelUtils.getRowIterator(sheet, 
_configuration, false);
+        final int rowLength = row.getLastCellNum();
+        int eagerness = _configuration.getEagerness();
+        final ColumnType[] columnTypes = new ColumnType[rowLength];
+
+        while (data.hasNext() && eagerness-- > 0) {
+            final Row currentRow = data.next();
+            if (currentRow.getRowNum() < 
_configuration.getColumnNameLineNumber()) {
+                continue;
+            }
+            for (int index = 0; index < rowLength; index++) {
+                if (currentRow.getLastCellNum() == 0) {
+                    continue;
+                }
+
+                ColumnType columnType = columnTypes[index];
+                ColumnType expecetedColumnType = 
getColumnTypeFromRow(currentRow, index);
 
 Review comment:
   done with next commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services